Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup vm-console-proxy operand #515

Merged
merged 1 commit into from Mar 9, 2023
Merged

refactor: cleanup vm-console-proxy operand #515

merged 1 commit into from Mar 9, 2023

Conversation

codingben
Copy link
Member

@codingben codingben commented Mar 8, 2023 •
edited

What this PR does / why we need it:

Refactor some operand functions and rename them,
and improve code readability.

Release note:

None

@codingben
Copy link
Member Author

/cc @akrejcir

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 8, 2023
@codingben codingben mentioned this pull request Mar 8, 2023
Closed
@codingben codingben requested review from akrejcir and removed request for lyarwood and ksimon1 March 9, 2023 08:52
@codingben
refactor: cleanup vm-console-proxy operand
69d17c3 
Refactor some operand functions and rename them,
and improve code readability.

Signed-off-by: Ben Oukhanov <boukhanov@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akrejcir
Copy link
Collaborator

akrejcir commented Mar 9, 2023

Looks good.
Can you remove the release note from the PR's description? Release note should contain information that is relevant for the user. Refactoring is not important for users.

/lgtm

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 9, 2023
@codingben
Copy link
Member Author

@akrejcir Ah okay, I thought every change in user's code should also require release note.

@akrejcir
Copy link
Collaborator

akrejcir commented Mar 9, 2023

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@kubevirt-bot kubevirt-bot merged commit bba0032 into kubevirt:master Mar 9, 2023
akrejcir added a commit to akrejcir/ssp-operator that referenced this pull request May 2, 2023
@akrejcir
fix: correctly delete proxy resources if namespace is not "kubevirt"
f2d07b4 
Cleanup() method of vm-console-proxy deletes resources from the correct namespace.

Manual backport of b72b74f.

NOTE: The PR could not be trivially backported, because intermediate PRs
were not backported, and that caused git conflicts. To fix the
conflicts, unit tests were not included.
- Refactoring PR: kubevirt#515
- PR that adds more unit tests: kubevirt#509

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@codingben codingben deleted the CNV-25395-cleanup branch June 28, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrejcir akrejcir Awaiting requested review from akrejcir

Assignees

@akrejcir akrejcir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codingben @akrejcir @kubevirt-bot