Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update common-templates to v0.29.0 #989

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Update common-templates to v0.29.0 #989

merged 1 commit into from
Jun 3, 2024

Conversation

ksimon1
Copy link
Member

@ksimon1 ksimon1 commented Jun 3, 2024

Update common-templates bundle to v0.29.0
Release note:

Update common-templates bundle to v0.29.0

@ksimon1
Update common-templates bundle to version v0.29.0
a4e7fb6 
Signed-off-by: Common-templates Release Automation <ksimon@redhat.com>
@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 3, 2024
@kubevirt-bot kubevirt-bot requested a review from 0xFelix June 3, 2024 14:27
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jun 3, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@akrejcir
Copy link
Collaborator

akrejcir commented Jun 3, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024
0xFelix
0xFelix approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2024
@kubevirt-bot kubevirt-bot merged commit d6c79fd into kubevirt:main Jun 3, 2024
11 of 12 checks passed
@ksimon1
Copy link
Member Author

ksimon1 commented Jun 3, 2024

/cherrypick release-v0.20

@kubevirt-bot kubevirt-bot mentioned this pull request Jun 3, 2024
Merged
@kubevirt-bot
Copy link
Contributor

@ksimon1: new pull request created: #990

In response to this:

/cherrypick release-v0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ksimon1 ksimon1 deleted the update-common-templates-v0.29.0 branch July 25, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix 0xFelix approved these changes

@lyarwood lyarwood Awaiting requested review from lyarwood

Assignees

@0xFelix 0xFelix

@akrejcir akrejcir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ksimon1 @akrejcir @kubevirt-bot @0xFelix