Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apparmor: Recommend removing libvirt package #618

Merged
merged 1 commit into from
Nov 23, 2022
Merged

apparmor: Recommend removing libvirt package #618

merged 1 commit into from
Nov 23, 2022

Conversation

andreabolognani
Copy link
Contributor

Making local modifications to the AppArmor profile works, but (where possible) uninstalling the libvirt package also does the trick and is a much simpler workaround, so recommend that.

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Nov 9, 2022
@andreabolognani andreabolognani mentioned this pull request Nov 9, 2022
Closed
@andreabolognani
Copy link
Contributor Author

@vasiliy-ul please take a look :)

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2022
@andreabolognani
Copy link
Contributor Author

Can anyone please approve the PR, and maybe explain why all the CI jobs have failed? I'm just tweaking a couple of paragraphs, so I would hardly expect that to ruffle automation's feathers.

@rmohr
Copy link
Member

rmohr commented Nov 23, 2022

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
@rmohr
Copy link
Member

rmohr commented Nov 23, 2022

/retest

@maiqueb
Copy link
Contributor

maiqueb commented Nov 23, 2022

/retest

... blindly assuming CI took a tumble.

@rmohr
Copy link
Member

rmohr commented Nov 23, 2022

/retest

... blindly assuming CI took a tumble.

Not sure if retest works, given that these jobs are not run inside a prow job, or triggered via a prowjob. @andreabolognani would you mind running git commit --amend and resubmitting to trigger these jobs again?

@andreabolognani
apparmor: Recommend removing libvirt package
c688792 
Making local modifications to the AppArmor profile works, but
(where possible) uninstalling the libvirt package also does the
trick and is a much simpler workaround, so recommend that.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2022
@andreabolognani
Copy link
Contributor Author

would you mind running git commit --amend and resubmitting to trigger these jobs again?

@rmohr done. I think #624 might have fixed things in the meantime.

maiqueb
maiqueb approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2022
@kubevirt-bot kubevirt-bot merged commit d483acc into kubevirt:main Nov 23, 2022
@andreabolognani andreabolognani deleted the apparmor branch November 23, 2022 14:29
victortoso pushed a commit to victortoso/kubevirt-user-guide that referenced this pull request Jan 16, 2023
@andreabolognani @victortoso
apparmor: Recommend removing libvirt package (kubevirt#618)
04261f0 
Making local modifications to the AppArmor profile works, but
(where possible) uninstalling the libvirt package also does the
trick and is a much simpler workaround, so recommend that.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiqueb maiqueb maiqueb approved these changes

@vasiliy-ul vasiliy-ul vasiliy-ul approved these changes

@davidvossel davidvossel Awaiting requested review from davidvossel

@mazzystr mazzystr Awaiting requested review from mazzystr

Assignees

@maiqueb maiqueb

@vasiliy-ul vasiliy-ul

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andreabolognani @rmohr @kubevirt-bot @maiqueb @vasiliy-ul