Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Add kubevirt-web-ui-components and required scss files #17

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

rawagner
Copy link

No description provided.

Copy link

@mareklibra mareklibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM considering frontend/public/style.scss already imports patternfly's variables and other requirements

I don't like this case-by-case import. Might be hard to maintain in the future when i.e. paternfly-react adds additional styling for these components (on top of patternfly).
I understand, this is the way how openshift/console imports this stuff and so we should follow.

Writing that just to keep us careful in the future, this might change so we will adapt web-ui accordingly.

@mareklibra
Copy link

mareklibra commented Sep 26, 2018

Will be merged together with #18 .

Blocked by kubevirt/web-ui-components#27 and subsequent release of web-ui-components

@mareklibra
Copy link

Final note: the yarn.lock is not included. I believe this is not an issue considering fact that just web-ui-components has been added. And this will help us avoid merge conflicts with openshift/console.

@mareklibra
Copy link

kubevirt-web-ui-components 0.1.2 published, restarting tests

@mareklibra
Copy link

Requires #19

@mareklibra
Copy link

All green, merging

@mareklibra mareklibra merged commit 503fc3a into kubevirt:master Sep 26, 2018
@vojtechszocs
Copy link

Final note: the yarn.lock is not included. I believe this is not an issue considering fact that just web-ui-components has been added. And this will help us avoid merge conflicts with openshift/console.

This is not an issue 😃 when a dependency resolution is missing in yarn.lock, Yarn will simply download the latest version that matches semver range declared in package.json. Since we generally want to use the latest version of kubevirt-web-ui-components, that's perfectly fine.

@rawagner rawagner deleted the add_kubevirt_components branch September 27, 2018 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants