-
Notifications
You must be signed in to change notification settings - Fork 11
Add kubevirt-web-ui-components and required scss files #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM considering frontend/public/style.scss
already imports patternfly's variables and other requirements
I don't like this case-by-case import. Might be hard to maintain in the future when i.e. paternfly-react adds additional styling for these components (on top of patternfly).
I understand, this is the way how openshift/console imports this stuff and so we should follow.
Writing that just to keep us careful in the future, this might change so we will adapt web-ui accordingly.
Will be merged together with #18 . Blocked by kubevirt/web-ui-components#27 and subsequent release of |
Final note: the |
|
Requires #19 |
72e6690
to
6bab942
Compare
All green, merging |
This is not an issue 😃 when a dependency resolution is missing in |
No description provided.