fix: check if settings field is not nil. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds additional tests to trigger a nil pointer dereference in the policy execution. This can happen because the policy settings fields are pointer which can be nil when user does not want to validate those resources. This commit adds two tests to simulate this situation. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com> wip Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
The settings fields could be nil when user does not define the settings for some of the resource type. Therefore, when the policy access the field to check if it should ignores the values defined by the user, the policy must check if the settings is not nil first. Thus, a method has been added to encapsulate this logic. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
|
@TechDufus, can you test this fix as well? Thanks! |
|
@jvanz I'm no longer seeing the policy crash, but I'd like to let this run until tomorrow to see if the audit-scanner picks up on me having a deployment beyond my defined allowed limit. :) |
|
SHIP IT TO PROD. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The settings fields could be nil when user does not define the settings for some of the resource type. Therefore, when the policy access the field to check if it should ignores the values defined by the user, the policy must check if the settings is not nil first. Thus, a method has been added to encapsulate this logic.
Fix #27
Test
make annotated-policy.wasm test e2e-tests --always-makeAlso try it out in a running policy server. I'll keep a tag with this fix in my ghcr.io registry for a while