Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New architecture #51

Merged
merged 8 commits into from
Sep 23, 2021
Merged

New architecture #51

merged 8 commits into from
Sep 23, 2021

Conversation

raulcabello
Copy link
Contributor

fixes #49

@raulcabello
Update the "architecture" section
9d8e0ba 
- architecture section
- architecture new images
@raulcabello
Update the "architecture" section
9a37a9b 
- quick start updated to reflect new PolicyServer resource
@raulcabello
Copy link
Contributor Author

I forgot to add the serviceaccount filed to the PolicyServer resource, I'll add it now

raulcabello and others added 2 commits September 22, 2021 11:39
@raulcabello
Update the "architecture" section
06c6f79 
- add serviceAccountName to PolicyServer
@flavio
Update architecture.md
3288617 
Some minor fixes
flavio
flavio reviewed Sep 22, 2021
View reviewed changes
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left some suggestions/comments

src/quick-start.md Outdated Show resolved Hide resolved
src/quick-start.md Outdated Show resolved Hide resolved
src/quick-start.md Outdated Show resolved Hide resolved
src/quick-start.md Outdated Show resolved Hide resolved
src/quick-start.md Outdated Show resolved Hide resolved
src/quick-start.md Outdated Show resolved Hide resolved
src/quick-start.md Outdated Show resolved Hide resolved
src/quick-start.md Outdated Show resolved Hide resolved
src/quick-start.md Outdated Show resolved Hide resolved
src/quick-start.md Outdated Show resolved Hide resolved
viccuad
viccuad reviewed Sep 22, 2021
View reviewed changes
src/quick-start.md Show resolved Hide resolved
src/quick-start.md Outdated Show resolved Hide resolved
ereslibre
ereslibre reviewed Sep 22, 2021
View reviewed changes
src/quick-start.md Outdated Show resolved Hide resolved
src/quick-start.md Outdated Show resolved Hide resolved
@raulcabello
Update the "quick start" section
fddce20 
 - Add status info
 - Remove pre-delete hook documentation
@viccuad viccuad self-requested a review September 22, 2021 15:41
viccuad
viccuad approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine from my side :). I will open a PR with cert-manager things once the chat changes land.

ereslibre
ereslibre approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

viccuad
viccuad reviewed Sep 23, 2021
View reviewed changes
src/quick-start.md Outdated Show resolved Hide resolved
@viccuad
Copy link
Member

viccuad commented Sep 23, 2021

Added 2 commits for adding cert-manager as dependency and installing it in the quick-start. Hope it's ok.

@viccuad viccuad mentioned this pull request Sep 23, 2021
Closed
4 tasks
flavio
flavio approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the great work!

@raulcabello raulcabello merged commit 84fdabe into kubewarden:new-architecture Sep 23, 2021
@raulcabello raulcabello deleted the new-architecture branch September 23, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viccuad viccuad viccuad approved these changes

@flavio flavio flavio approved these changes

@ereslibre ereslibre ereslibre approved these changes

@jvanz jvanz Awaiting requested review from jvanz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raulcabello @viccuad @ereslibre @flavio