fix: Push to ghcr without duplicating chart name #174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
helm push expects
helm push <path_to_chart> <registry>
, not<registry>/chart_name
.Fixes overly long URIs for charts in ghcr:
https://github.com/kubewarden/helm-charts/pkgs/container/charts%2Fkubewarden-controller%2Fkubewarden-controller
Test
Tested by running the shellscript locally.
expand
Example: https://ghcr.io/viccuad/test-charts/charts/kubewarden-controller
Additional Information
Tradeoff
Potential improvement