-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default policy server settings #70
Add default policy server settings #70
Conversation
charts/kubewarden-controller/templates/policyserver-default.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but this will change once we have a separate chart for the default PolicyServer
I would love to find a way of installing the 3 charts, and use the same values file. That way we could use the same default PolicyServer
name. I'm not sure if that is possible
Converting to draft until prerequisites are merged and figured out. |
kubewarden/kubewarden-controller#175 was merged too and unblocked this. I'm going to rebase this PR on top of main. |
When a policy server is not provided, the controller will default the policy server if required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks ok to me, but with this we have 3 values files (1 per chart), plus the global values. I would prefer to merge them all into global values already, to only need one yaml as UX. But we can do that in a follow-up PR that closes #76.
This discussion goes on at #76 |
Converting to draft because if published the toplevel |
Based on the discussions on issue #76 I have updated this PR to be a middle ground.
This allows a user to reuse the same If we agree to go on with that I think we can add some automation as @viccuad proposed for linting and ensuring that we don't get key overrides. This task could be done afterwards this merges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the effort on this topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @ereslibre!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -16,4 +16,4 @@ maintainers: | |||
version: 0.4.2 | |||
|
|||
# This is the version of kubewarden-controller container image to be used | |||
appVersion: "v0.5.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be changed very soon, when we release the helm chart too.
Fixes: #76
This adds a global
values.yaml
file that can be consumed by the subcharts on certain attributes that might be shared across them.For installation, the current documentation can be followed, running:
You can read more about global values at https://helm.sh/docs/chart_template_guide/subcharts_and_globals/#global-chart-values