fix: do not exit when k8s' matchConditions are not available #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not exit with an error when the `matchConditions` field is not available for ValidatingWebhookConfiguration and MutatingWebhookConfiguration. The code is already structured to work when this feature is not available, hence we don't have to cause the controller to exit with an error. Fixes kubewarden#900 Signed-off-by: Flavio Castelli <fcastelli@suse.com>
viccuad
approved these changes
Oct 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #901 +/- ##
==========================================
+ Coverage 70.53% 70.65% +0.11%
==========================================
Files 30 30
Lines 2559 2559
==========================================
+ Hits 1805 1808 +3
+ Misses 584 582 -2
+ Partials 170 169 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
flavio
deleted the
do-not-exit-when-admission-match-conditions-are-not-available
branch
|
For completion, the check performed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not exit with an error when the
matchConditionsfield is not available for ValidatingWebhookConfiguration and MutatingWebhookConfiguration.The code is already structured to work when this feature is not available, hence we don't have to cause the controller to exit with an
error.
Fixes #900