-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RFC 10, Rancher integration of policies #12
Add RFC 10, Rancher integration of policies #12
Conversation
60fb23d
to
e90cceb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great analysis 👏
I propose a variation on the alternative approach which is an hybrid between the core proposal and alternative "A":
- Store the additional information inside of the Wasm metadata
- Have a tool that reads the embedded metadata and produces as output all the Rancher helm chart files
The rest would work like the core proposal. What do you think?
As an example of a Helm chart for a policy, see kubewarden/allow-privilege-escalation-psp-policy#30. This example is implemented directly in the |
Looking at the contents created via kubewarden/allow-privilege-escalation-psp-policy#30, I think the only reasonable thing to include inside of the policy metadata would be the |
Co-authored-by: Flavio Castelli <flavio@castelli.me>
Co-authored-by: Flavio Castelli <flavio@castelli.me>
Committed clarification of points, and reworded to use folder instead of branch.
It also provides a simple airgap story for the metadata (download Helm charts, mirror OCI wasm modules). I still favour Alternative B (use OCI's We just need a client that can pull the manifest of an artifact from an OCI registry (e.g: 30 secs search, https://github.com/Pixeladed/oci-registry-js), and to do so on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @viccuad ! I don't think it is a good idea to place kubewarden policies in https://github.com/rancher/charts
In my opinion we should leave https://github.com/rancher/charts just for apps that can be deployed in your cluster (kubewarden for example)
We could create a separate chart repository for the policies something like https://github.com/rancher/kubewarden-policies-charts. Drawback is that users would need to add it manually, or would it possible to add this new repository when kubewarden is installed? (I don't think that's possible, but I'm not sure..)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We might need to make some modifications in the future based on the feedback we get for the questions.yaml and where to place the policies. I'm happy merging this now.
Thanks for the hard work @viccuad!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :D
Thank you @viccuad for this work!
Merging! we can make adjustments later on. |
Description
Relates to #7
Rendered RFC.