Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing problem with split CSS chunks with multiple outputs #86

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

netlas
Copy link
Contributor

@netlas netlas commented May 27, 2024

Proposition for a fix to the problem discussed in #85 .

@netlas
Copy link
Contributor Author

netlas commented May 27, 2024

irshadahmad21's pull request #77 got accidentally merged in this pull request as well.

@kucrut
Copy link
Owner

kucrut commented Jun 13, 2024

Thank you for the pull request @netlas.

Could you resolve the conflict and remove the changes introduced by #77 from your PR? It would also be nice if you could also format the code to follow the coding standard (composer lint should give you clues on the CS violations).

@netlas
Copy link
Contributor Author

netlas commented Jun 13, 2024

I removed the conflicts and adjusted the code to pass the composer lint

@kucrut
Copy link
Owner

kucrut commented Jun 13, 2024

Thank you for the PR update. From my local testing, this seem to work as intended except that the stylesheets are enqueued twice because each has different "parent" JS file.

I'll merge this PR and create an issue to fix the duplication.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants