Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added paragraph about pod restart control #238

Merged
merged 2 commits into from
May 8, 2020
Merged

Added paragraph about pod restart control #238

merged 2 commits into from
May 8, 2020

Conversation

ANeumann82
Copy link
Member

Signed-off-by: Andreas Neumann aneumann@mesosphere.com

@ANeumann82
Added paragraph about pod restart control
0e7f45e 
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
@ANeumann82 ANeumann82 mentioned this pull request Apr 24, 2020
Merged
@meichstedt meichstedt requested review from zen-dog and nfnt May 7, 2020 12:34
nfnt
nfnt reviewed May 7, 2020
View reviewed changes
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but I find the second paragraph hard to comprehend. Is it saying that pods will only be restarted if resources affecting this pod (e.g. a ConfigMap) is updated?

content/docs/developing-operators/tasks.md Outdated Show resolved Hide resolved
@ANeumann82
Rephrased second paragraph
1612b54 
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
zen-dog
zen-dog approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM 🚢

nfnt
nfnt approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer, thank you! 🚢

@ANeumann82 ANeumann82 merged commit 56f3525 into master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfnt nfnt nfnt approved these changes

@zen-dog zen-dog zen-dog approved these changes

@meichstedt meichstedt Awaiting requested review from meichstedt meichstedt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ANeumann82 @nfnt @zen-dog