Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KUDO Allows for the update of a non-existent param #1411

Closed
kensipe opened this issue Mar 10, 2020 · 0 comments · Fixed by #1441
Closed

KUDO Allows for the update of a non-existent param #1411

kensipe opened this issue Mar 10, 2020 · 0 comments · Fixed by #1441
Assignees
@zen-dog
Labels
kind/bug
Milestone
0.12.0

Comments

@kensipe
Copy link
Member

kensipe commented Mar 10, 2020

What happened:

k kudo update --instance foo -p BAR=2 when BAR doesn't exist is allowed which seems like a bug.

I would expect that if any param in the series of provided params (command-line or file based) fails the update.
@kensipe kensipe added this to the 0.12.0 milestone Mar 10, 2020
@kensipe kensipe self-assigned this Mar 10, 2020
@porridge porridge mentioned this issue Mar 12, 2020
Merged
1 task
@zen-dog zen-dog assigned zen-dog and unassigned kensipe Mar 26, 2020
zen-dog added a commit that referenced this issue Mar 26, 2020
@zen-dog
Fix updating invalid Instance parameters
2e3c446 
Summary:
in the past we've allowed updating Instance with parameters that are missing in the corresponding OV (since there were no way to forbid this in the absence of an admission controller). Now that we have instance admission controller in place, we can fix this behavior.

Fixes #1411

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
@zen-dog zen-dog mentioned this issue Mar 26, 2020
Merged
zen-dog pushed a commit that referenced this issue Mar 31, 2020
Fix updating invalid Instance parameters (#1441)
98cee77 
Summary:
in the past, we've allowed updating Instance with parameters that are missing in the corresponding OV (since there was no way to forbid this in the absence of an admission controller). Now that we have an instance admission controller in place, we can fix this behavior.

Fixes #1411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zen-dog zen-dog

Labels
kind/bug
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Fix updating invalid Instance parameters kudobuilder/kudo
2 participants
@kensipe @zen-dog