Add API version for operator.yaml #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wdyt about promoting operator.yaml to v1beta1 @alenkacz ? we're a little more stable in that sense than alpha I think. |
|
@gerred updated |
|
lgtm other than the tests :D |
gerred
approved these changes
Oct 31, 2019
alenkacz
commented
Oct 31, 2019
| @@ -26,10 +26,10 @@ const ( | |||
| operatorFileName = "operator.yaml" | |||
| templateFileNameRegex = "templates/.*.yaml" | |||
| paramsFileName = "params.yaml" | |||
| ServerAPIVersion = "kudo.dev/v1alpha1" | |||
| PackageAPIVersion = "kudo.dev/v1beta1" | |||
There was a problem hiding this comment.
this will be again unified when these two versions align in the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds api version field to the operator.yaml. While working on this PR I made the following decisions (which could still be changed/discussed):
If we have more API versions we'll need to add more robust handling.
Fixes #1012