Update API server for tests #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
requested review from
gerred,
jbarrick-mesosphere,
kensipe and
zen-dog
as code owners
alenkacz
commented
Nov 6, 2019
| @@ -7,12 +7,11 @@ status: | |||
| kind: ProwJob | |||
| # InitialNamesAccepted will change from False -> True once the CRD is ready. | |||
| conditions: | |||
| - message: no conflicts found | |||
| reason: NoConflicts | |||
| - type: NonStructuralSchema | |||
There was a problem hiding this comment.
this is a list and we need to assert the whole list. Since some version of kubernetes, this new condition appeared so it had to be added.
|
btw. it's expected that this is failing because the mismatch of api server version. I won't merge before this turns green (which will when I push the image) |
gerred
approved these changes
Nov 6, 2019
jbarrick-mesosphere
approved these changes
Nov 6, 2019
zen-dog
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Kubernetes api server had a race back in 1.13 kubernetes/kubernetes#51353 and we're still seeing this in our tests because we're using api-server from 1.13.1 in tests. We run tests in docker and we use tools provided by kubebuilder release. We depend on 1.0.8 which is kube 1.13.1. By going to 2.X we;re at least moving to 1.15
I looked into ditching kubebuilder altogether because we're really just using api server and etcd but it would be a bit more work :) we could do it as follow-up if people find it meaningful.
If tests locally start to fail for you after this PR, it's because you need to update api server locally as well if you're not running tests inside docker.'
Oh and this is just first step of the fix - the real will be to actually push the golang 1.13 images to docker hub. I'll do it when this one is merged.
Fixes #683