Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connecting package verification to package creation #1089

Merged
merged 1 commit into from
Nov 20, 2019
Merged

connecting package verification to package creation #1089

merged 1 commit into from
Nov 20, 2019

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Nov 19, 2019

What this PR does / why we need it:

Fixes #1076

alenkacz
alenkacz approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@kensipe kensipe merged commit 519f965 into master Nov 20, 2019
@kensipe kensipe deleted the ken/package-create-verify branch November 20, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alenkacz alenkacz alenkacz approved these changes

@gerred gerred Awaiting requested review from gerred gerred is a code owner

@zen-dog zen-dog Awaiting requested review from zen-dog zen-dog is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package create should run verify
2 participants
@kensipe @alenkacz