Disallow only spec updates for now #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
requested review from
gerred,
kensipe,
nfnt and
zen-dog
as code owners
kensipe
approved these changes
Dec 9, 2019
| @@ -14,23 +15,29 @@ var _ kudo.Validator = &Instance{} | |||
|
|
|||
| // ValidateCreate implements webhookutil.validator (from controller-runtime) | |||
| // we do not enforce any rules upon creation right now | |||
| // ValidateCreate implements kudo.Validator (slightly tweaked interface originally from controller-runtime) | |||
There was a problem hiding this comment.
L16 and L18 make conflicting statements
There was a problem hiding this comment.
lol, good catch :) thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For now, we disallowed all updates except status updates. This narrows it down and just disallows updates to the spec that means:
This potentially narrows down issues with the webhook as controller etc. can update annotation or finalizers, which I think is fine even when plan is running.
Addition to #883