Remove some unused labels. #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
porridge
force-pushed
the
crd-diff
branch
2 times, most recently
from
6079816
to
a6cf258
Compare
alenkacz
requested changes
Dec 17, 2019
There was a problem hiding this comment.
I am not really rejecting per say but I need to understand something first before I can approve :)
So looking at the labels in our current init, this is how statefulset for manager looks like
selector:
matchLabels:
app: kudo-manager
control-plane: controller-manager
if we remove app from there, what will actually remain? How will the statefulset select the pods? I don't think that just control-plane: controller-manager is a good idea.
- remove the "app: kudo-manager" from CRDs, since it is not really used by anything, and will be hard to convince controller-gen to generate it when we switch to it - remove the controller-tools.k8s.io label, (which is not even used by controller-tools upstream any more) from EVERYWHERE
porridge
force-pushed
the
crd-rm-labels
branch
from
efd79f7
to
949bbad
Compare
|
@alenkacz note that I'm not removing the |
alenkacz
approved these changes
Dec 18, 2019
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
- remove the "app: kudo-manager" from CRDs, since it is not really used by anything, and will be hard to convince controller-gen to generate it when we switch to it - remove the controller-tools.k8s.io label, (which is not even used by controller-tools upstream any more) from EVERYWHERE Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
by anything, and will be hard to convince controller-gen to generate
it when we switch to it
controller-tools upstream any more) from EVERYWHERE
This is another baby step towards #862