Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update direct dependencies to their latest versions #1193

Merged
merged 4 commits into from
Dec 20, 2019

Conversation

nfnt
Copy link
Member

@nfnt nfnt commented Dec 17, 2019

What this PR does / why we need it:
Let's keep our dependencies up-to-date!
Kubernetes dependencies were excluded from this update, because they are a bit difficult to handle.
Notably, KinD was greatly refactored in version 0.6.0 and refactorings in the test harness were necessary to use the updated API.

Kubernetes dependencies were excluded from this update, because they are a bit difficult to handle.
Notably, KinD was greatly refactored in version 0.6.0 and refactorings in the test harness were necessary to use the updated API.
@nfnt nfnt added the dependencies Pull requests that update a dependency file label Dec 17, 2019
@nfnt nfnt self-assigned this Dec 17, 2019
@nfnt
Copy link
Member Author

nfnt commented Dec 18, 2019

The default version of Kubernetes used by KinD 0.6 has been changed from 1.15 to 1.16. The E2E tests are failing, because it tries to install an old versions of local-path-provider that uses the app/v1beta2 API for Deployment that has been removed on Kubernetes 1.16. This is fixed in kudobuilder/operators#168.

Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the red tests

@nfnt
Copy link
Member Author

nfnt commented Dec 19, 2019

@alenkacz PTAL at kudobuilder/operators#168 to get the tests green.

pkg/test/harness.go Outdated Show resolved Hide resolved
@nfnt nfnt merged commit 189b0ce into master Dec 20, 2019
@nfnt nfnt deleted the nfnt/update-deps branch December 20, 2019 11:12
ANeumann82 pushed a commit that referenced this pull request Feb 13, 2020
Kubernetes dependencies were excluded from this update, because they are a bit difficult to handle.
Notably, KinD was greatly refactored in version 0.6.0 and refactorings in the test harness were necessary to use the updated API.

Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants