Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'properties/assert' with 'testify/assert' #1248

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

nfnt
Copy link
Member

@nfnt nfnt commented Jan 7, 2020

What this PR does / why we need it:
This removes the "properties" dependency and uses "testify" instead. The main reason was that the assertions provided by "properties" didn't correctly show the line in which an assertion failed. "testify" does. E.g. "properties" showed assert.go:24: got 1.7.2 want flink app version while "testify" shows

    index_test.go:63: 
        	Error Trace:	index_test.go:63
        	Error:      	Not equal: 
        	            	expected: ""
        	            	actual  : "1.7.2"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-
        	            	+1.7.2
        	Test:       	TestParseIndexFile
        	Messages:   	flink app version

Also this improves code consistency by removing a package when we have other packages already providing that functionality.

This removes the "properties" dependency and uses "testify" instead.
@nfnt nfnt self-assigned this Jan 7, 2020
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@nfnt nfnt merged commit 3e2625e into master Jan 8, 2020
@nfnt nfnt deleted the nfnt/remove-properties-assert branch January 8, 2020 08:45
ANeumann82 pushed a commit that referenced this pull request Feb 13, 2020
This removes the "properties" dependency and uses "testify" instead.

Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants