Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEP 0004] Add Testing Infrastructure #126

Merged
merged 3 commits into from
Mar 7, 2019
Merged

[KEP 0004] Add Testing Infrastructure #126

merged 3 commits into from
Mar 7, 2019

Conversation

runyontr
Copy link
Member

No description provided.

Copy link
Member

@gerred gerred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, and had a question on future testing.

keps/20190218-add-testing-infrastructure.md Outdated Show resolved Hide resolved
keps/20190218-add-testing-infrastructure.md Outdated Show resolved Hide resolved
keps/20190218-add-testing-infrastructure.md Outdated Show resolved Hide resolved
keps/20190218-add-testing-infrastructure.md Outdated Show resolved Hide resolved



## Motivation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop section if unnecessary

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Motivation is the higher level item that contains Goals and Non-Goals as members

keps/20190218-add-testing-infrastructure.md Outdated Show resolved Hide resolved

## Motivation

### Goals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, do we want to create a definition of "mergeable" for other stories to set the baseline amount of testing required to merge future features once we pull ourselves out of the hole we've given ourselves? Is "tests must be included for new functionality" enough? Is it "overall code coverage can not go down in new PRs without entire group approval (for hard to test things)"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to have a definition/requirement like this. The downside of "code coverage" is now that's something we need to be able to track and compare between commits.

Depending on our CI tool, that could in theory be a warning that says "the code coverage went down" to give reviewers insight.

@runyontr runyontr changed the title First commit for testing kep [KEP 0004] Add Testing Infrastructure Feb 21, 2019
@runyontr runyontr added the kind/kep Kudo Enhancement label Feb 21, 2019
@gerred gerred merged commit c4848f7 into master Mar 7, 2019
fabianbaier pushed a commit that referenced this pull request Mar 8, 2019
* First commit for testing kep

* Spelling fixes

* Set KEP to implementable
fabianbaier pushed a commit that referenced this pull request Mar 8, 2019
* First commit for testing kep

* Spelling fixes

* Set KEP to implementable
authors:
- "@runyontr"
owners:
- @runyontr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/@runyontr/"@runyontr"

needs name in double quotes

## Summary

As the complexity and scope of KUDO grows, it becomes impossible to manually validate
exisiting frameworks and capabilities still function as expected. As part of a robust
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/exisiting/existing


* Ensure validation of API objects is functioning correctly
* Ensure controllers execute known process flows correctly
* Validate Framework and FrameworkVersions in kudobuilder/frameworks adhere to the API spec defined by Kudo. Provide common
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Kudo/KUDO

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Provide/\n* Provide

misconfigurations and validate the testing framework notifies the users/developer of failure
* Reduce review time for code changes by not requiring reviewers to validate functionality of test cases
* Reduce developer time for code changes by providing tools to validate functionality
* Provide developers clear tooling for addition additional tests to infrastructure to validate bug fixes and new features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ addition/

@gkleiman gkleiman deleted the kep-add-testing branch June 4, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/kep Kudo Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants