Cleanup finalizer removal in instance update #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
zen-dog
reviewed
Mar 4, 2020
| @@ -271,7 +271,11 @@ func updateInstance(instance *kudov1beta1.Instance, oldInstance *kudov1beta1.Ins | |||
|
|
|||
| // 1. check if the finalizer can be removed (if the instance is being deleted and cleanup is completed) and then | |||
| // update instance spec and metadata. this will not update Instance.Status field | |||
| isDelete := tryRemoveFinalizer(instance) | |||
| isDeletionComplete := false | |||
There was a problem hiding this comment.
Still misleading IMHO, because the DELETE is complete when the Instance is removed, which is not the case here. We could call it what it is: isFinalizerRemoved (1) or what it means to us: isCleanupDone (2). I'd prefer the first one.
There was a problem hiding this comment.
Actually, the result from tryRemoveFinalizer is not important for us, that could also happend on an upgrade if the cleanup plan is removed. I've pushed another version...
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
Co-authored-by: Ken Sipe <kensipe@gmail.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only try to remove finalizers if we're actually in the deletion process
Signed-off-by: Andreas Neumann aneumann@mesosphere.com