KEP-29: instance controller reconciliation for parent instances #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
zen-dog
commented
Jun 8, 2020
| @@ -208,19 +208,6 @@ func wasRunAfter(p1 PlanStatus, p2 PlanStatus) bool { | |||
| return p1.LastUpdatedTimestamp.Time.After(p2.LastUpdatedTimestamp.Time) | |||
| } | |||
|
|
|||
| // GetExistingParamDefinitions retrieves parameter metadata from OperatorVersion | |||
zen-dog
commented
Jun 8, 2020
| @@ -137,7 +137,7 @@ func instanceResource(instanceName, operatorName, operatorVersionName, namespace | |||
| }, | |||
| Status: v1beta1.InstanceStatus{}, | |||
| } | |||
| if err := controllerutil.SetControllerReference(owner, instance, scheme); err != nil { | |||
| if err := controllerutil.SetOwnerReference(owner, instance, scheme); err != nil { | |||
There was a problem hiding this comment.
This is the actual change: with SetOwnerReference reconciliation will be called for the parent instance
zen-dog
commented
Jun 8, 2020
| @@ -1,5 +1,15 @@ | |||
| apiVersion: kudo.dev/v1beta1 | |||
| kind: Instance | |||
| metadata: | |||
There was a problem hiding this comment.
Parent instance is now also COMPLETE
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
ANeumann82
approved these changes
Jun 9, 2020
nfnt
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com