Updates to local run #1580
Merged
Updates to local run #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
zen-dog
approved these changes
Jul 9, 2020
test/README.md
Outdated
| @@ -149,6 +155,8 @@ webhooks: | |||
|
|
|||
| The difference between this one and the one generate by the `kudo init --unsafe-self-signed-webhook-ca` command, (see this [method](pkg/kudoctl/kudoinit/prereq/webhook.go:163) for more information) is the usage of `webhooks[].clientConfig.url` (which points to our ngrok-tunnel) instead of `webhooks[].clientConfig.Service`. | |||
|
|
|||
| **note:** The url used by ngrok changes for each run of ngrok. It is possible to get the current url with `curl -s localhost:4040/api/tunnels | jq '.tunnels[1].public_url'` | |||
There was a problem hiding this comment.
I think it's more complicated than it should be: the tunnel only exists while the ngrok is running in your terminal window and it already gives you the URL. No need to get it from the API.
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ken Sipe kensipe@gmail.com
I'm very interested in making this easier... but this is step 1.