Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a missing implicit. #1630

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Add a missing implicit. #1630

merged 2 commits into from
Aug 6, 2020

Conversation

porridge
Copy link
Member

@porridge porridge commented Aug 5, 2020

What this PR does / why we need it:

The allowlist in verifier got out of sync with reality and package create rejects an otherwise valid package.

Fixes #

@porridge
Add a missing implicit.
ec5f60a 
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
ANeumann82
ANeumann82 requested changes Aug 5, 2020
View reviewed changes
Copy link
Member

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this "implicitis" variable here.

We should use the ones from the renderer package and remove the double definitions here.

implicts := renderer.NewVariableMap().WithDefaults()

That one should stay up-to-date if new vars are added.

@ANeumann82
Remove additional list of implicits and use the one from the renderer…
d63ac4a 
… with defaults

Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
porridge
porridge commented Aug 5, 2020
View reviewed changes
Copy link
Member Author

@porridge porridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

kensipe
kensipe approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@alenkacz alenkacz merged commit 0f5c2df into main Aug 6, 2020
@alenkacz alenkacz deleted the porridge/operatorversion branch August 6, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zen-dog zen-dog zen-dog approved these changes

@nfnt nfnt nfnt approved these changes

@ANeumann82 ANeumann82 ANeumann82 approved these changes

@zmalik zmalik zmalik approved these changes

@kensipe kensipe kensipe approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz alenkacz is a code owner

@gerred gerred Awaiting requested review from gerred

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@porridge @kensipe @zmalik @ANeumann82 @nfnt @zen-dog @alenkacz