Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Verify Installation for --wait on init #1662

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

ANeumann82
Copy link
Member

@ANeumann82 ANeumann82 commented Aug 26, 2020

What this PR does / why we need it:
Instead of monitoring the statefulset of the KUDO manager, we can use the installers VerifyInstallation to wait for all resources to be healthy.

Fixes #1653

@ANeumann82 ANeumann82 changed the title An/use verify installation for wait Use Verify Installation for --wait on init Aug 26, 2020
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

@ANeumann82 ANeumann82 merged commit 8358371 into main Aug 27, 2020
@ANeumann82 ANeumann82 deleted the an/use-verify-installation-for-wait branch August 27, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KUDO init --wait should reuse code in InstallVerifier if possible
3 participants