Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to wait for an instance uninstall #1682

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Conversation

nfnt
Copy link
Member

@nfnt nfnt commented Sep 14, 2020

What this PR does / why we need it:
Similar to the 'wait' and 'wait-time' options for operator package installations, instance uninstalls can be waited upon to complete.

Fixes #1665

Similar to the 'wait' and 'wait-time' options for operator package installations, instance uninstalls can be waited upon to complete.

Signed-off-by: Jan Schlicht <jan@d2iq.com>
@nfnt nfnt added the component/cli kubectl kudo a.k.a. kudoctl label Sep 14, 2020
@nfnt nfnt self-assigned this Sep 14, 2020
@nfnt nfnt added this to the 0.17.0 milestone Sep 14, 2020
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/kudoctl/util/kudo/kudo.go Show resolved Hide resolved
@nfnt nfnt merged commit 397aa37 into main Sep 15, 2020
@nfnt nfnt deleted the nfnt/uninstall-wait branch September 15, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cli kubectl kudo a.k.a. kudoctl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --wait option to KUDO uninstall CLI command
3 participants