Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resources to be in subdirectories #1700

Merged
merged 6 commits into from
Oct 1, 2020

Conversation

ANeumann82
Copy link
Member

What this PR does / why we need it:

Allow usage of subdirectories in the templates folder

Fixes #1695

Signed-off-by: Andreas Neumann aneumann@mesosphere.com

Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, I have just one nit. Thank you 👏

pkg/kudoctl/packages/reader/parser.go Outdated Show resolved Hide resolved
ANeumann82 and others added 3 commits September 30, 2020 18:18
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe and others added 2 commits September 30, 2020 15:53
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@kensipe kensipe merged commit 7099ac2 into main Oct 1, 2020
@kensipe kensipe deleted the an/allow-subdirectory-resources branch October 1, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folders in the "templates" folder
4 participants