Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of the appVersion when resolving dependencies #1722

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

zen-dog
Copy link
Contributor

@zen-dog zen-dog commented Oct 16, 2020

Summary:
This is necessary due to a recent change in OV naming rules: KUDO now uses the appVersion in the OV name if it exists and so we need to set it when KudoOperatorTaskSpec package is resolved.

Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com

Summary:
This is necessary due to a recent [change](5e7546b) in OV naming rules: KUDO now uses the `appVersion` in the OV name if it exists and so we need to set it when `KudoOperatorTaskSpec` package is resolved.

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏
Thank you!

@zen-dog zen-dog merged commit 086302e into main Oct 16, 2020
@zen-dog zen-dog deleted the ad/fix-kot-appversion branch October 16, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants