Fixes nil map bug on creation #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
|
we need to look at this... the e2e-test is failing on the bison install... but it isn't clear why. |
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
alenkacz
approved these changes
Nov 16, 2020
|
thanks @alenkacz ! |
kensipe
added a commit
that referenced
this pull request
Nov 16, 2020
Co-authored-by: Alena Varkockova <varkockova.a@gmail.com> Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
added a commit
that referenced
this pull request
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ken Sipe kensipe@gmail.com
It appears no one tested creating a new instance with this release of kudo. I don't see how it could have worked.
This was tested working on konvoy 1.6-rc4 with
kudobuilder/controller:devwhich was dev build with the solution.We will look at making sure we have a test solution after we get this bug fix out.
Fixes #1742