Fix kudo init --verify on cluster without KUDO #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe and
zen-dog
as code owners
alenkacz
reviewed
Jan 20, 2021
| @@ -111,6 +111,10 @@ func (k *KudoWebHook) verifyWithCertManager(client *kube.Client, result *verifie | |||
| if err := k.validateCertManagerInstallation(client, result); err != nil { | |||
| return err | |||
| } | |||
| if !result.IsValid() { | |||
There was a problem hiding this comment.
wait so verifier returns errors but you still have to check the result? 🤔 that's kind of error-prone...
There was a problem hiding this comment.
Yeah, it is... It's about different things:
- The return value determines if there was an error in the validation process
- The result contains errors that the validation detected
In hindsight it would be better to have just the result and handle the validation exceptions there as well...
There was a problem hiding this comment.
Yeah that sounds like better design probably...
alenkacz
approved these changes
Jan 20, 2021
| @@ -111,6 +111,10 @@ func (k *KudoWebHook) verifyWithCertManager(client *kube.Client, result *verifie | |||
| if err := k.validateCertManagerInstallation(client, result); err != nil { | |||
| return err | |||
| } | |||
| if !result.IsValid() { | |||
There was a problem hiding this comment.
Yeah that sounds like better design probably...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andreas Neumann aneumann@mesosphere.com
What this PR does / why we need it:
Don't throw exception when running kudo init --verify against a cluster without KUDO
Fixes #1753