Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up - indent install-crds alternative #250

Merged
merged 1 commit into from
May 17, 2019

Conversation

TattdCodeMonkey
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Indented the bullet item for alternatively using kubectl to install CRDs. This should allow the make run bullet item to stay at the same level as the other steps and not be rendered to the same line after kubectl apply -f config/crds

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Indented the bullet item for alternatively using kubectl to install
CRDs. This should allow the `make run` bullet item to stay at the same
level as the other steps and not be rendered to the same line
after `kubectl apply -f config/crds`
@runyontr runyontr self-requested a review May 17, 2019 12:58
Copy link
Member

@runyontr runyontr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joerg84 joerg84 merged commit 92ab12a into kudobuilder:master May 17, 2019
@joerg84
Copy link
Contributor

joerg84 commented May 17, 2019

Thanks @TattdCodeMonkey !

@TattdCodeMonkey TattdCodeMonkey deleted the getting-started/fixup branch May 17, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants