Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test #264

Merged
merged 2 commits into from
May 24, 2019
Merged

Fix failing test #264

merged 2 commits into from
May 24, 2019

Conversation

alenkacz
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
This test was failing. I think that it was asserting incorrect message. The credentials provided in that case are invalid so we cannot hit the rate limiter response.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@runyontr runyontr self-requested a review May 24, 2019 09:29
Copy link
Member

@runyontr runyontr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Squash and Merge

@alenkacz alenkacz merged commit 2a91980 into master May 24, 2019
@alenkacz alenkacz deleted the av/fix-credentials-test branch May 30, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants