Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to Go text/template #295

Merged
merged 14 commits into from
Jun 6, 2019
Merged

Change to Go text/template #295

merged 14 commits into from
Jun 6, 2019

Conversation

gerred
Copy link
Member

@gerred gerred commented Jun 5, 2019

This is basic, but works. There's a larger PR coming that starts to move other logic up into the engine package, such as assembling all of the values from a FrameworkVersion (to move that out of FV), but this is simple and gets people unblocked.

@gerred gerred changed the title Initial commit on templating engine. Currently, toy.yaml has been updated to Go Templates. Change to Go text/template Jun 5, 2019
@gerred gerred requested a review from alenkacz June 5, 2019 13:16
@gerred
Copy link
Member Author

gerred commented Jun 5, 2019

cc @fabianbaier once this lands we'll need to coordinate during our release process updating all of our frameworks, and making others aware that v0.2.0 completely supersedes v0.1.0. We're pre-1.0 so there's obviously no expectation of stability here.

cc-ing @mattj-io @yankcrime @guenter, this will affect any demos or presentations you do once the frameworks repo is updated to match. After that, you'll need to use v0.2.0 for anything.

config/samples/canary.yaml Outdated Show resolved Hide resolved
@@ -242,23 +242,23 @@ spec:
apiVersion: apps/v1
kind: StatefulSet
metadata:
name: {{FRAMEWORK_NAME}}
namespace: {{NAMESPACE}}
name: {{ .FrameworkName }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These non-parameter varaibles should be layed out in documentation somewhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of KEP-9's Execution State section. I'll open a separate PR updating KEP-9 once the dust settles on that and we get your PR + new install method all in.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Then, we also need to write actual docs based on that section)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the exact same thought as Tom 👍 should we maybe track it in an issue?

Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked surprisingly small. Nice! :)

config/samples/canary.yaml Outdated Show resolved Hide resolved
config/samples/flink.yaml Show resolved Hide resolved
@@ -242,23 +242,23 @@ spec:
apiVersion: apps/v1
kind: StatefulSet
metadata:
name: {{FRAMEWORK_NAME}}
namespace: {{NAMESPACE}}
name: {{ .FrameworkName }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the exact same thought as Tom 👍 should we maybe track it in an issue?

@gerred gerred merged commit 06e17c3 into master Jun 6, 2019
@gerred gerred deleted the templating-engine branch June 6, 2019 11:39
@gerred
Copy link
Member Author

gerred commented Jun 6, 2019

Closes #268

@fabianbaier
Copy link
Member

cc @fabianbaier once this lands we'll need to coordinate during our release process updating all of our frameworks, and making others aware that v0.2.0 completely supersedes v0.1.0. We're pre-1.0 so there's obviously no expectation of stability here.

cc-ing @mattj-io @yankcrime @guenter, this will affect any demos or presentations you do once the frameworks repo is updated to match. After that, you'll need to use v0.2.0 for anything.

Frameworks have been updated kudobuilder/operators#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants