Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for immutable client IP bug #446

Conversation

jbarrick-mesosphere
Copy link
Member

@jbarrick-mesosphere jbarrick-mesosphere commented Jun 28, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

What this PR does / why we need it:

Reproduce a bug in KUDO:

2019/06/28 01:49:40 Going to apply patch
{"metadata": {"annotations": {}}, "spec": {"clusterIP":null,"ports":[{"name":"gossip","port":80,"targetPort":0}],"sessionAffinity":null}}

 to object
&Service{ObjectMeta:k8s_io_apimachinery_pkg_apis_meta_v1.ObjectMeta{Name:my-instance-svc,GenerateName:,Namespace:kudo-test-adapting-parakeet,SelfLink:/api/v1/namespaces/kudo-test-adapting-parakeet/services/my-instance-svc,UID:fded0ced-9946-11e9-9081-0242ac110002,ResourceVersion:98,Generation:0,CreationTimestamp:2019-06-28 01:49:39 +0000 UTC,DeletionTimestamp:<nil>,DeletionGracePeriodSeconds:nil,Labels:map[string]string{app: ,heritage: kudo,instance: my-instance,version: 1.0,},Annotations:map[string]string{phase: deploy,plan: deploy,planexecution: my-instance-deploy-573106463,step: deploy,},OwnerReferences:[{kudo.k8s.io/v1alpha1 Instance my-instance fdc1eaaf-9946-11e9-9081-0242ac110002 0xc000bf675c 0xc000bf675d}],Finalizers:[],ClusterName:,Initializers:nil,ManagedFields:[],},Spec:ServiceSpec{Ports:[{gossip TCP 80 {0 80 } 0}],Selector:map[string]string{app: ,heritage: kudo,instance: my-instance,label: test,version: 1.0,},ClusterIP:10.0.0.198,Type:ClusterIP,ExternalIPs:[],SessionAffinity:None,LoadBalancerIP:,LoadBalancerSourceRanges:[],ExternalName:,ExternalTrafficPolicy:,HealthCheckNodePort:0,PublishNotReadyAddresses:false,SessionAffinityConfig:nil,},Status:ServiceStatus{LoadBalancer:LoadBalancerStatus{Ingress:[],},},}
2019/06/28 01:49:40 PlanExecutionController: CreateOrUpdate Patch: Service "my-instance-svc" is invalid: spec.clusterIP: Invalid value: "": field is immutable

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@jbarrick-mesosphere jbarrick-mesosphere merged commit 40f8a46 into kudobuilder:master Jun 28, 2019
@jbarrick-mesosphere jbarrick-mesosphere deleted the immutable-client-ip branch June 28, 2019 02:16
@jbarrick-mesosphere jbarrick-mesosphere added this to the v0.3.0 milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants