Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding notes for installation via url #514

Merged
merged 5 commits into from
Jul 29, 2019
Merged

adding notes for installation via url #514

merged 5 commits into from
Jul 29, 2019

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Jul 7, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/component kudoctl
/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@kensipe kensipe requested a review from gerred as a code owner July 7, 2019 21:14
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting kind of challenging now, because we release site from master, so right now it will contain informations from unreleased version. Do we ignore it for now? Is it time to maybe address that somehow? Thoughts? @kensipe @gerred

I am fine with ignoring it and postponing this feature to later stages but this will come back... and when we have real community members we should pay attention to not put tutorials out there for stuff that will be released in 3 weeks.

@gerred
Copy link
Member

gerred commented Jul 8, 2019

It's probably time to address this. I think the easiest is going to be moving the site to a new repo, so that one branch is always the reflection of the live site, and master is the next version which gets deployed by Netlify onto a subdomain. wdyt?

@kensipe
Copy link
Member Author

kensipe commented Jul 8, 2019

@alenkacz While I see value in working this out... I don't see it as a concern for this PR

@gerred
Copy link
Member

gerred commented Jul 8, 2019

Agreed @kensipe, just want to hold the PR since it'll automatically update the site. Going to sort it out separately with a new repository and updating Netlify, and then you'll be safe to merge.

@alenkacz
Copy link
Contributor

alenkacz commented Jul 8, 2019

@kensipe I needed a way to stop this PR from merging - I needed to have that discussion and did not want two other people to come and just blindly approve and then we just merge it 🤷‍♀ . I assume requesting changes is the github way to stop merging a PR so I used it... feel free to dismiss my review when the docs release process is resolved.

@kensipe
Copy link
Member Author

kensipe commented Jul 8, 2019

totally makes sense!

@kensipe kensipe added this to the v0.4.0 milestone Jul 9, 2019
@kensipe kensipe added the hold label Jul 9, 2019
@kensipe kensipe merged commit 7b3470d into master Jul 29, 2019
@alenkacz alenkacz deleted the ken/install-notes branch October 30, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants