Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install into non-default namespace #515

Merged
merged 4 commits into from
Jul 8, 2019
Merged

Conversation

alenkacz
Copy link
Contributor

@alenkacz alenkacz commented Jul 8, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Right now it was not able to install into specific namespace.

Which issue(s) this PR fixes:
Fixes #344

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixed a bug when using `kudo install --namespace xxx` was not respected. It was not possible to install into non-default namespace

@alenkacz alenkacz changed the title Av/fix installation ns Fix install into non-default namespace Jul 8, 2019
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kensipe kensipe merged commit 73e29ce into master Jul 8, 2019
alenkacz added a commit that referenced this pull request Jul 9, 2019
* Fixed a bug when using `kudo install --namespace xxx` was not respected. It was not possible to install into non-default namespace
@alenkacz alenkacz deleted the av/fix-installation-ns branch October 30, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify Frameworkversion reference in instance
3 participants