Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specific names for test objects #555

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Use specific names for test objects #555

merged 2 commits into from
Jul 11, 2019

Conversation

alenkacz
Copy link
Contributor

@alenkacz alenkacz commented Jul 11, 2019

At many places in controller logs we just print out the name of the objects. I find it easier to navigate then when using test-specific names (not just namespace).

Copy link
Member

@fabianbaier fabianbaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We needed that test!

@kensipe kensipe merged commit 7f417ba into master Jul 11, 2019
@alenkacz alenkacz deleted the av/use-specific-names branch October 30, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants