Support installing a CRD in a test step and using it in a later test step. #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarrick-mesosphere
requested review from
alenkacz,
kensipe,
fabianbaier and
runyontr
gerred
approved these changes
Jul 18, 2019
|
This is a pretty large change to the harness, so I'm going to run it in a loop and make sure it doesn't introduce any issues before merging. |
jbarrick-mesosphere
force-pushed
the
crd-step
branch
from
f2b3661
to
7ee6687
Compare
jbarrick-mesosphere
added a commit
to jbarrick-mesosphere/kudo
that referenced
this pull request
Jul 19, 2019
…in a later test step. (kudobuilder#595)"" This reverts commit 7528d85d3720634ee90e862714bc168adbdfa07f.
jbarrick-mesosphere
added a commit
that referenced
this pull request
Jul 23, 2019
…in a later test step."" (#610) * Revert "Revert "Support installing a CRD in a test step and using it in a later test step. (#595)"" This reverts commit 7528d85d3720634ee90e862714bc168adbdfa07f. * Fix panic when schemes are modified after clients are in use. * add storedVersions to status check in assert * fix CRD race * Make testutils.Scheme threadsafe using sync.Once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
This allows a user to include CRDs in test steps and use them in later test steps. Prior to this, all CRDs had to be included in the
crdDir, which could be messy depending on the test case (e.g., I wanted to write a test for the harness for a CRD that is explicitly not included in the runtime scheme and don't want to polluteconfig/crds).Also re-enabled the test suite in
pkg/test/test_data/to run the harness integration tests as we were not running them before and I needed to write a test.Which issue(s) this PR fixes:
N/A but unblocks a test for a feature
Special notes for your reviewer:
Does this PR introduce a user-facing change?: