Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul test harness documentation. #643

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

jbarrick-mesosphere
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This overhauls the test harness documentation to be better.

Special notes for your reviewer:

These docs are for 0.4.0 release. So, some of the things in here are aspirational:

  • We don't yet have a krew plugin.
  • CLI testing is not yet implemented.

Does this PR introduce a user-facing change?:

NONE

Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great docs 👏


To write a test case:
Now that the kudo CLI is installed, we can write a test. The KUDO test CLI organizes tests into suites:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe say somewhere that a suite has to always live in a separate directory?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh or the first level of folders is actually cases and one more level is suites, right? okay, that was not obvious to me on first read :) (just noting, in case you know how to improve on that)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, so a test suite could actually be multiple directories since testDirs is a list, so I was avoiding talking about directories in the definitions section. I'm gonna think about this one some more.

docs/testing.md Outdated Show resolved Hide resolved
* [Getting a resource from the cluster](#getting-a-resource-from-the-cluster)
* [Listing resources in the cluster](#listing-resources-in-the-cluster)

# Format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be ## ? as a sub-section

Copy link
Member Author

@jbarrick-mesosphere jbarrick-mesosphere Jul 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incidentally, the only reason I included a title at the top is our Hugo style omits the page title. Should I maybe fix the style and drop the titles at the top of the page (I wasn't sure if that was intentional or not)?

docs/testing/asserts.md Show resolved Hide resolved
docs/testing/steps.md Show resolved Hide resolved
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I love the added tips!!!

docs/testing/reference.md Outdated Show resolved Hide resolved
@jbarrick-mesosphere jbarrick-mesosphere modified the milestones: v0.4.0, v0.3.3, 0.5.0 Jul 26, 2019
@kudo-ci
Copy link

kudo-ci commented Jul 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alenkacz, jbarrick-mesosphere, kensipe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alenkacz,jbarrick-mesosphere,kensipe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Use a nested menu for testing docs

Make a note about the assertion timeout

Make a note that test steps and asserts are both optional

talk about how objects in a test step are operated on simultaneously.

specify that deletion expects objects to not exist

update tips about CRD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants