Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs and test renames to ease debugging #648

Merged
merged 4 commits into from
Jul 25, 2019
Merged

Logs and test renames to ease debugging #648

merged 4 commits into from
Jul 25, 2019

Conversation

alenkacz
Copy link
Contributor

Two minor imrovements added in this PR that will help debugging some remaining flakes:

  • logs added to createPlan. Currently we only had events and those are not printed in logs
  • rename of objects in one of the tests, that was sharing names with other test

@alenkacz alenkacz mentioned this pull request Jul 25, 2019
Merged
@kensipe
Copy link
Member

kensipe commented Jul 25, 2019

resolved merge conflict

@kensipe kensipe merged commit fa217f9 into master Jul 25, 2019
@alenkacz alenkacz deleted the av/better-debugging branch October 30, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbarrick-mesosphere jbarrick-mesosphere jbarrick-mesosphere approved these changes

@kensipe kensipe kensipe approved these changes

@gerred gerred Awaiting requested review from gerred gerred is a code owner

@runyontr runyontr Awaiting requested review from runyontr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alenkacz @kensipe @jbarrick-mesosphere