Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update and upgrade docs #700

Merged
merged 6 commits into from
Aug 8, 2019
Merged

Add update and upgrade docs #700

merged 6 commits into from
Aug 8, 2019

Conversation

alenkacz
Copy link
Contributor

@alenkacz alenkacz commented Aug 6, 2019

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Adds missing docs for upgrade and update command added in 0.5.0.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise 🚢 !

docs/cli.md Outdated Show resolved Hide resolved
docs/cli.md Outdated Show resolved Hide resolved
docs/cli.md Outdated Show resolved Hide resolved
docs/cli.md Outdated Show resolved Hide resolved
docs/cli.md Outdated

New version of that operator is installed to the cluster and `upgrade` (or `deploy`) plan is started to roll out new flink pods updated to the newer version.

At the same time we're overriding value of parameter `param`. That is optional, you can always do it in separate step via `kudo update`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
At the same time we're overriding value of parameter `param`. That is optional, you can always do it in separate step via `kudo update`.
At the same time, we're overriding value of parameter `param`. That is optional and you can always do it in separate step via `kudo update`.

Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great with @zen-dog's comments / nits... otherwise... great additions!

alenkacz and others added 5 commits August 7, 2019 09:25
Co-Authored-By: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Co-Authored-By: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Co-Authored-By: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Co-Authored-By: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
@jbarrick-mesosphere
Copy link
Member

/approve

@kudo-ci
Copy link

kudo-ci commented Aug 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alenkacz, jbarrick-mesosphere, kensipe, zen-dog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alenkacz,jbarrick-mesosphere,kensipe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zen-dog zen-dog merged commit 82bf2ee into master Aug 8, 2019
@kudo-ci kudo-ci deleted the av/update-upgrade-docs branch August 8, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants