Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove make manifest #786

Merged
merged 3 commits into from
Sep 11, 2019
Merged

Remove make manifest #786

merged 3 commits into from
Sep 11, 2019

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Sep 10, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #780

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't forget to drop the manifests as well :)

@kudo-ci
Copy link

kudo-ci commented Sep 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alenkacz, kensipe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kudo-ci kudo-ci added size/L and removed size/M labels Sep 11, 2019
@kensipe
Copy link
Member Author

kensipe commented Sep 11, 2019

@alenkacz I captured the concerns you identified in #798
It is possible we have a manifests target again in Makefile which invokes the kudo init --crd-only for check-in. That said... we need #784 to land first.

Thanks for the detailed review!!!

@kensipe kensipe merged commit f513b1a into master Sep 11, 2019
@kudo-ci kudo-ci deleted the ken/remove-manifest-gen branch September 11, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Make Manifests
3 participants