Repo Index Merge #801
Merged
Repo Index Merge #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
gerred
approved these changes
Sep 12, 2019
kensipe
force-pushed
the
ken/repo-merge
branch
from
6906b97
to
fd87792
Compare
alenkacz
requested changes
Sep 13, 2019
There was a problem hiding this comment.
I am sorry, I had to request changes for two reasons:
- I don't know how merge works in helm and I did not understand how I would use the flags just from the command line docs. I think we need examples and some better description in the cmd itself
- maybe I missed something but I feel like we don't have the actual merging unit tested - since merging two things is a potentially brittle operation it would be nice to have that covered. I am fine with extracting merge to a special method and unit testing just
merge(index1, index2)that should be fairly simple to write :) I am just curious how that works actually - is the left always right? How merge deals with items present on both sides? I would like those be covered by unit tests (and documented also in the cmd).
kensipe
force-pushed
the
ken/repo-merge
branch
from
3daf9ed
to
f9ef0fc
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alenkacz, gerred, kensipe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…we are consistent
kensipe
force-pushed
the
ken/repo-merge
branch
from
3dbf062
to
47dd085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/component kudoctl
/kind feature
What this PR does / why we need it:
kudo repo index --mergekudo repo index --merge-repoWhich issue(s) this PR fixes:
Fixes #769
Special notes for your reviewer:
Looking to add some more tests tomorrow
Does this PR introduce a user-facing change?: