Run operators tests #806
Run operators tests #806
Conversation
jbarrick-mesosphere
force-pushed
the
e2e-tests
branch
2 times, most recently
from
155ba4e
to
506278a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gerred, jbarrick-mesosphere The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jbarrick-mesosphere
force-pushed
the
e2e-tests
branch
from
506278a
to
b24bd70
Compare
|
Is this still owned by anyone? @jbarrick-mesosphere do you have time to get this across the line? If not, no worries, we will re-assign it. |
I’d been waiting for the 0.7.0 release (I believe that was the cause of the failures) and now I’m just waiting for a good time to fix the PR. But if you want to reassign it, please do! It’s quite possible all that is needed here is a rebase. |
|
Hey @justinbarrick no worries! Not in a rush on this, I won't directly re-assign we'll just see who gets to it first. :) I just wanted to make sure it was still even relevant (we've had some older PRs that weren't even needed anymore). |
jbarrick-mesosphere
force-pushed
the
e2e-tests
branch
from
b24bd70
to
f28780a
Compare
fix make docker privs add go-junit-report add docker CLI to test dockerfile fix docker cli install fix docker run command fix docker fix networking remove CMD from dockerfile E2E test additions (#958) * Introduce integration test for restart (#718) This introduces and integration test that: - creates instance - waits for deploy on that instance is finished - stops controller - updates instance CRD in the meantime - starts controller - verifies update plan was run This test was failing prior to the instance controller refactoring (the old controller logic was handling this wrong) * Fix namespace handling for plan command (#925) * Include CRDs in the -o yaml --dry-run (#923) * go mod changes makes repo dirty. this resolves that (#926) * Fix deep copy and don't modify original state (#919) * Fixes the release workflow for Docker images * Attempt to fix 'TestCheckResourceIntegration' flaky test (#914) * Do not use strategicmergepatch for CRDs (#936) * Plan status should show last executed plan, not just active plan (#931) * More consistent logging for install (#933) * fixing repo merge by name bug (#938) * Use built in isExists (#942) * Make it possible to opt out of junit (#950) * Maintainers is array, not object (#930) * Handle already exists in flaky test (#941) * Cleanup lastexecutedplan method to remove the flake (#949) * Fix docs for instance name in install (#943) * add namespace flag for kudo init (#903) * Fix 'run_tests' script * Use a shell script for E2E test commands The script is similar to the one used for integration tests. This also allows to not use JUnit output. * Copy E2E test script into test container * Fix permissions of E2E test script * Distinguish between local and operator E2E tests Tests in the 'test/e2e' folder are run as part of the E2E tests in addition to the operator tests.
jbarrick-mesosphere
force-pushed
the
e2e-tests
branch
from
c184a10
to
694a51a
Compare
There was a problem hiding this comment.
This is great!
Small nit: The CircleCI test jobs are named test-1 and test-2 in the Github UI. I'll see how this can be changed to integration-test and e2e-test and commit the change on this branch. Once this is merged, the project settings have to be changed to make these tests required instead of the obsolete "test" step.
While using parameters reduces code-duplication, the job names shown in a Github PR will be 'test-1' and 'test-2'. This is avoided by using separate jobs. Now, 'integration-test' and 'e2e-test' will be shown.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: