Kubernetes Version Server Check For Kudo Install #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quired field for operators
kensipe
requested review from
alenkacz,
fabianbaier and
gerred
as code owners
kensipe
commented
Sep 17, 2019
kensipe
commented
Sep 17, 2019
fabianbaier
approved these changes
Sep 18, 2019
alenkacz
requested changes
Sep 18, 2019
There was a problem hiding this comment.
So with this PR we made kubernetes version a required field, but it was not a required field so far. There are operators that will be broken by this https://github.com/kudobuilder/operators/blob/master/repository/redis/operator/operator.yaml so we need to fix the operators or make it optional again.
My personal preference is to make it optional because if I am not using any special kubernetes features I am fine with running the operator on all k8s versions kudo can run on. Also ... helm has that optional as well.
alenkacz
approved these changes
Sep 18, 2019
There was a problem hiding this comment.
Please address this one, the naming is still a bit confusing to me. Otherwise LGTM #836 (comment)
porridge
added
release/highlight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding check of operator requested kubernete version against the server.
kubernetesVersionis now a required field for operatorsWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: