Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init wait-timeout invalid without wait #897

Merged
merged 1 commit into from
Oct 4, 2019
Merged

init wait-timeout invalid without wait #897

merged 1 commit into from
Oct 4, 2019

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Oct 4, 2019

What this PR does / why we need it:
Better UX

Fixes #

@gerred
Copy link
Member

gerred commented Oct 4, 2019

do you know why those indirect deps got added? pflag added them maybe?

@kensipe
Copy link
Member Author

kensipe commented Oct 4, 2019

I'll double check...

@kensipe
Copy link
Member Author

kensipe commented Oct 4, 2019

looks like master is dirty... from master if you go mod tidy you get the same

@kensipe kensipe merged commit 07692b7 into master Oct 4, 2019
@kensipe kensipe deleted the ken/wait-time-valid branch October 4, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zen-dog zen-dog zen-dog approved these changes

@gerred gerred gerred approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz alenkacz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kensipe @gerred @zen-dog