update to init namespace changes #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
reviewed
Oct 17, 2019
There was a problem hiding this comment.
I am still not a huge fan of global flags but this LGTM
I think we need to also deal with this to be able to consider this a full follow-up of that community PR (output of running kudo init help)
Target namespace for the object. (default "default") ... right now our CLI help is lying about the default for init - that is actually the part I consider the hardest with global flags, but maybe I just don't see some very straightforward solution someone else does :)
gerred
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
minor updates to init namespace changes
add on to: #903
Fixes #