Make sure config/crds are always up to date for testing #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
changed the title
zen-dog
approved these changes
Oct 22, 2019
| crds := cmdinit.CRDs() | ||
|
|
||
| if false { | ||
| // change this to true if you want to one time override the manifests with new values |
There was a problem hiding this comment.
Wouldn't it be nice to have a make test-crds which would call into a main() method (can be in this test file) that writes the manifests? Instead of manually changing false -> true here? Just an idea
There was a problem hiding this comment.
I'll leave that as an exercise for someone who is not comfortable with the true/false situation 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the past, we generated manifests using
/config/manifests. Then we switched to kudo init. Nowkudo initshould be the ultimate source of truth but at the same time, we still have/config/manifestsfile with usually obsolete manifests that are causing cryptic test failures.This PR removes this tech debt. Instead of removing
/config/crds, I went the way of generating them from init in tests and then writing test that always ensures that these are up to date with what init provides. The manifests are right now used e.g. when test harness starts - the harness expects folder with CRDs so this was one solution of how to provide it (I find it the easier one).This is a replacement of #857