Better engine package structure #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files around plan execution engine has been rearranged: TL;DR: - `/pkg/engine` folder is now home to all plan execution related files - we're now clearly separating between `rendering` engine and `workflow` engine - `plan_execution_engine.go` was moved from the instance controller to the `/pkg/engine/workflow` This is the new structure overview: ``` ├── renderer │ ├── engine.go │ └── engine_test.go ├── task │ ├── doc.go │ ├── enhancer.go │ ├── render.go │ ├── task.go │ ├── task_apply.go │ ├── task_apply_test.go │ ├── task_delete.go │ ├── task_delete_test.go │ ├── task_dummy.go │ ├── task_dummy_test.go │ └── task_test.go └── workflow │ ├── engine.go │ └── engine_test.go ├── metadata.go ``` No functional changes were made in this PR.
|
nice refactoring, I love this. makes it really obvious where to look for things. |
|
Can you stub out small doc.go module docs for each new package as entrypoints into those? |
alenkacz
added a commit
that referenced
this pull request
Oct 24, 2019
What this PR does / why we need it: This is a follow-up of #992 where we wanted to move enhancer into the rendering package but just did not manage to do that. This PR moves it there plus the metadata from tasker, that is actually rendering metadata so it belongs there. This also moves template package and health package into the engine and does a bit of renaming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files around plan execution engine have been rearranged: TL;DR:
/pkg/enginefolder is now home to all plan execution-related filesrenderingengine andworkflowengineplan_execution_engine.gowas moved from the instance controller to the/pkg/engine/workflowThis is the new structure in overview:
No functional changes were made in this PR.